Fix analysis and code format issues #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 49.62% // Head: 49.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 49.62% 49.70% +0.07%
==========================================
Files 18 18
Lines 2702 2682 -20
==========================================
- Hits 1341 1333 -8
+ Misses 1361 1349 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sub6Resources
changed the title
Sub6Resources
force-pushed
the
fix/analysis-issues
branch
from
c096700
to
c53cb80
Compare
Sub6Resources
force-pushed
the
fix/analysis-issues
branch
from
c53cb80
to
29899c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite: #1147
This pull request seeks to clean up our codebase by adding a CI check for formatting and analysis issues. This will raise a flag so we don't merge unformatted code or code with analysis issues.
After adding the checks, the analyzer brought up 300 suggestions (but only one warning 🎉 ), so this pull request is going to touch a LOT of files. It fixes currently existing analysis and formatting issues.
Most of the changes are trivial (formatting/code style), so I'll list any non-trivial changes here:
remcase forCssBoxWidgetinlib/src/css_box_widget.dartDisplay.blockandListStyleType.upperAlpha)