Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SelectableHtml not rebuild when data change #1111

Merged
merged 1 commit into from
May 9, 2023
Merged

fix SelectableHtml not rebuild when data change #1111

merged 1 commit into from
May 9, 2023

Conversation

docaohuynh
Copy link
Contributor

SelectableHtml State change doesn't refresh the widget

erickok
erickok approved these changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@erickok erickok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Sub6Resources
Copy link
Owner

Initial scan looks good. I just need to run some tests.

Thank you!

@Trinhqn
Copy link

Trinhqn commented Sep 17, 2022 via email

@Sub6Resources
Copy link
Owner

Thank you so much for this contribution! I'll merge this, but unfortunately with #1176 removing support for SelectableHtml, the change won't be utilized. I apologize for being too slow to get this in!

@Sub6Resources Sub6Resources merged commit 298b986 into Sub6Resources:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickok erickok erickok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@docaohuynh @Sub6Resources @Trinhqn @erickok @docaohuynhcse