Fix image source matcher tests so they actually run correctly #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickok
approved these changes
Jun 11, 2022
There was a problem hiding this comment.
So nice to see you back @Sub6Resources and this is a great first step to better tests. I see nothing wrong here (but will later run them to see if I can break anything without a test failing).
|
I'm going to go ahead and merge. If there's a poorly written test, we'll work through that. Still plenty of testing left to do. |
|
Ah yes forgot to say I ran the tests yesterday and it's looking good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw that we have failing tests and found a bunch of tests for image source
CustomRenderMatchers that were created, but never properly finished. I rewrote them to run the test for the expected behavior.No library changes, just some new tests so we can have a full set of passing tests on master to set the foundation as we add more comprehensive testing across the board.