Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-native-maps (and replace with Mapbox) #2429

Merged
merged 12 commits into from
Mar 14, 2018

Conversation

drewvolz
Copy link
Member

@drewvolz drewvolz commented Mar 14, 2018

@hawkrives did work to replace react-native-maps in favor of react-native-map-box-gl.

The bonus is -- #2306 compiles and runs once this PR is integrated. So we get to perform the RN upgrade.

If we keep using react-native-maps, otoh, react-native-maps/react-native-maps#2053 won't let us actually run the app.

@drewvolz drewvolz requested a review from a team March 14, 2018 05:16
@drewvolz drewvolz changed the base branch from master to mapbox March 14, 2018 05:17
@hawkrives hawkrives changed the title Remove rn maps Remove react-native-maps (and replace with Mapbox) Mar 14, 2018
@hawkrives
Copy link
Member

This will eventually be used by my fancy campus map implementation that's currently incubating in CARLS

@hawkrives hawkrives changed the base branch from mapbox to greenkeeper/react-native-0.54.0 March 14, 2018 05:19
@drewvolz
Copy link
Member Author

that's currently incubating

marinating 🍲

@stodevx-bot
Copy link

stodevx-bot commented Mar 14, 2018

Warnings
⚠️

The Xcode project file changed. Maintainers, double-check the changes!

⚠️

Could not get info from npm on @mapbox/react-native-mapbox-gl

New dependencies added: @mapbox/react-native-mapbox-gl.

Generated by 🚫 dangerJS

Copy link
Member

@rye rye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞

@hawkrives
Copy link
Member

@rye 👞

@stodevx-bot
Copy link

stodevx-bot commented Mar 14, 2018

iOS Report

Analysis of slow build times (>20s)
1m 18s: AllAboutOlaf/AllAboutOlaf [Release]
  0m 56s: Running script 'Bundle React Native code and images'
0m 26s: React/double-conversion [Release]
  0m 25s: Running script 'Install Third Party'
0m 14s: React/third-party [Release]
0m 11s: Bugsnag/BugsnagStatic [Release]
1m 09s: React/React [Release]
0m 10s: RCTMGL/RCTMGL [Release]
0m 29s: React/cxxreact [Release]

Generated by 🚫 dangerJS

@hawkrives hawkrives merged commit 996eeac into greenkeeper/react-native-0.54.0 Mar 14, 2018
@hawkrives hawkrives deleted the remove-rn-maps branch March 28, 2018 02:03
@rye rye added this to the v2.6 milestone Jul 20, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants