Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Conditional Attribute Binding for the multiple Attribute in the File Selector Fragment #1665

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Aug 12, 2024

Description

Previous State:
The multiple attribute in the <input> element of the file selector fragment was statically defined, meaning it was either always present or always absent, regardless of the actual requirement. There was no way to dynamically set this attribute based on the multiple variable managed in the JavaScript code.

Fix:
This fix introduces conditional binding for the multiple attribute using Thymeleaf, based on the value of the multiple variable in the JavaScript. As a result, the attribute is only added if multiple is set to true, making the file selector's behavior dynamic and more flexible.

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner August 12, 2024 16:00
@github-actions github-actions bot added the Front End Issues related to front-end development label Aug 12, 2024
@Frooodle
Copy link
Member

:o oops

@Frooodle Frooodle merged commit f176558 into Stirling-Tools:main Aug 12, 2024
4 checks passed
@Ludy87 Ludy87 deleted the fix_multiple_file branch August 19, 2024 18:37
@Ludy87 Ludy87 restored the fix_multiple_file branch August 23, 2024 07:55
@Ludy87 Ludy87 deleted the fix_multiple_file branch August 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front End Issues related to front-end development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants