Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix UI crash when url is unrechable #1642

Merged

Conversation

sorydi3
Copy link
Contributor

@sorydi3 sorydi3 commented Aug 8, 2024

Description

Issue:1577

  • Implemented a check to verify if the domain is reachable before initiating the transformation. If the domain is not reachable, an exception is thrown.
  • Added unit tests to verify the functionality of converting a website to PDF, including scenarios where the domain is not reachable.

Closes #(1577)

Before Changes:

Screenshot 2024-08-08 at 12 10 44

After Changes:

Screenshot 2024-08-08 at 12 08 19

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@sorydi3 sorydi3 requested a review from Frooodle as a code owner August 8, 2024 10:39
@github-actions github-actions bot added Java Pull requests that update Java code API API-related issues or pull requests labels Aug 8, 2024
@Frooodle
Copy link
Member

Frooodle commented Aug 8, 2024

Seems tests are failing in github

@sorydi3
Copy link
Contributor Author

sorydi3 commented Aug 8, 2024

umm I'll take a look ,locally all test are passing thought. it is a bit strange.

@Frooodle Frooodle enabled auto-merge (squash) August 8, 2024 20:33
@Frooodle Frooodle merged commit 148feda into Stirling-Tools:main Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API-related issues or pull requests Java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants