Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error When Submitting Crop Tool Without Making a Selection #1354

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

foivospro
Copy link
Contributor

Description

This pull request addresses the issue where an error occurs if the crop tool form is submitted without making a selection.

Changes Made

Added logic to set default values for x, y, width, and height inputs if no selection is made. This ensures the entire PDF is selected by default when the form is submitted without any user selection.

Closes #1342

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@foivospro foivospro requested a review from Frooodle as a code owner June 1, 2024 11:01
Copy link

sonarcloud bot commented Jun 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Frooodle Frooodle merged commit fcd4af2 into Stirling-Tools:main Jun 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error if you hit submit on crop tool without making a selection.
2 participants