Fix issue with Poisson noise in lag spectra #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
+ Coverage 92.79% 93.46% +0.66%
==========================================
Files 43 43
Lines 8762 8762
==========================================
+ Hits 8131 8189 +58
+ Misses 631 573 -58 ☔ View full report in Codecov by Sentry. |
mgullik
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Hi @matteobachetti,
good catch!
I'm wondering why the tests didn't catch this?
Do you think we are doing the wrong tests?
|
I think that it just makes little difference in the high-SNR case that we test. Yes, Ideally we should have caught this before :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #741
We had a bug in the calculation of the Poisson noise level, which was highly overestimated. This produced some wrong results in the error calculation.