Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent nan in the rms calculation #736

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

mgullik
Copy link
Collaborator

@mgullik mgullik commented Jun 6, 2023

Also, it checks the last frequency allowed to compute rms
Add tests

Add control to the last frequency allowded to compute rms
Add tests
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #736 (e62358a) into main (3a7e816) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   97.17%   97.15%   -0.03%     
==========================================
  Files          42       42              
  Lines        7865     7872       +7     
==========================================
+ Hits         7643     7648       +5     
- Misses        222      224       +2     
Impacted Files Coverage Δ
stingray/fourier.py 99.74% <100.00%> (+<0.01%) ⬆️
stingray/powerspectrum.py 99.45% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@matteobachetti
Copy link
Member

matteobachetti commented Jun 8, 2023

Hi @mgullik, thanks for your PR!
The enable_deprecations_as_warnings issue that makes the devdeps test fail is partially solved in commit #cc2a561bbf770fd269a82b9aa3704c303a36dc2c, feel free to cherry-pick.
For the changelog issue, please add a file called 736.bugfix.rst to docs/changes with a sentence describing your fix

@matteobachetti matteobachetti added this pull request to the merge queue Jun 9, 2023
Copy link
Member

@matteobachetti matteobachetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mgullik, I added a couple of small modifications to fix the unrelated test failures, which will be corrected more robustly in #738.

Merged via the queue into StingraySoftware:main with commit 23a692c Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants