-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for React 17 #18
Comments
Thanks for raising this, I will resolve as soon as possible. |
This might help with fixing the issue: |
@hichemfantar I'm struggling to reproduce the error. I have successfully updated the advanced demo to use StrictMode and version 17 of React: https://codesandbox.io/s/advanced-react-page-transition-demo-z8hmd. I have also successfully updated the basic demo to use StrictMode and version 17 of React: |
Weird, It's working now. Maybe it's because I'm using node 12 now instead of 14 like I was before. |
Ok it seems like It's working on both now. Have no idea what I messed up previously. |
Thank you for looking into this for me. I'm seeing the console warning too, i will try to resolve it this week. |
Cool man, looking forward to the fix! |
I still get this error. |
Apparently this is an issue with react-transition-group |
Apparently there's no official fix for this and all the workarounds have certain pitfalls. |
That's not a bad shout. I have a lot of experience with Framer Motion. Switching to it would remove a lot of the configuration and make the whole thing a lot more plug and play. |
Looking forward to the switch to framer motion, I believe you'll bump this library to the next major version since it would probably be incompatible with the previous release. |
See: #33 |
React 17 causes this warning:
Disabling strict mode doesn't fix the issue.
The text was updated successfully, but these errors were encountered: