Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playing Card API bug fixes #34

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

Aurelius7309
Copy link
Collaborator

Fixes:

  • Fix a bug with get_straight deviating from the base game's behavior, not allowing five card straights with four fingers
  • Fix an issue with is_face not accounting for stone cards properly, causing stone cards that were face cards originally to be considered face cards
  • Address an issue where added playing cards are unloaded on profile/language change.

Known issues:

  • The playing card API currently does not offer multi-language support, and any information inserted regarding new playing cards is erased when changing languages. This will be implemented at a later date.

@Aurelius7309
Copy link
Collaborator Author

New commit fixes an issue with cards not being reachable starting from Aces in get_straight. Also I removed the upper card limits in get_flush and get_straight, as this is an irrelevant case in the base game, and removing it allows mods to check if the entirety of cards held in hand can make specific hands.

@Aurelius7309 Aurelius7309 merged commit 4bfd4d5 into Steamopollys:main Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant