StatsdMetricsHandler: Delegate to NoOpStatsHandler when configuring invalid UDP endpoint
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 2, 2022 13:18
deanward81
requested changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more sophisticated attempt at solving the issue outlined in #48.
Similarly to the
SignalFxMetricHandler, this PR changes theStatsdMetricHandlerto wrap an internal_activeHandlerproperty that either points to an actualBufferedStatsdMetricHandler(which is effectively the formerStatsdMetricHandler) or aNoOpMetricHandlerif the UDP host/port configuration suggests that we're not pointing to anything reasonable.This allows users to deactivate the
StatsdMetricHandlerby passingnull/0ashostandportproperties, and to activate it by passing a valid UDP endpoint.