Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add short-hand registry getters #2372

Merged
merged 3 commits into from
Dec 28, 2021
Merged

[WIP] Add short-hand registry getters #2372

merged 3 commits into from
Dec 28, 2021

Conversation

Zidane
Copy link
Member

@Zidane Zidane commented Jul 4, 2021

For Game/Server scope, a REGISTRY field

For world scope, a static util method that is passed a ServerWorld

SpongePowered/Sponge@cb8be18

Signed-off-by: Chris Sanders zidane@spongepowered.org

@Zidane
Copy link
Member Author

Zidane commented Jul 4, 2021

@zml2008 Be kind :)

Additionally, could probably elect to not do a method for GAME/SERVER scope but was having issues keeping it "clean"

@Zidane
Copy link
Member Author

Zidane commented Jul 13, 2021

@Grinch will continue this one.

@dualspiral dualspiral added the api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) label Jul 14, 2021
Zidane and others added 3 commits December 28, 2021 13:38
For Game/Server scope, a REGISTRY field

For world scope, a static util method that is passed a ServerWorld

Signed-off-by: Chris Sanders <zidane@spongepowered.org>
We could keep it for GAME scope but then it is so inconsistent...

Signed-off-by: Chris Sanders <zidane@spongepowered.org>
Signed-off-by: Steven Downer <grinch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) status: wip system: registry type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants