Implement error-prone for basic analysis #2344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error-prone is an AP that runs as part of the Java compile performing some helpful checks.
The tool is fairly lenient, and won't fail the build for things that it isn't super confident are bugs. When run on Sponge, it emitted quite a few warnings, but the errors it emitted appeared to all be legitimate bugs.
This came up almost accidentally when I changed IntelliJ to use error-prone for its own compilation, which ended up affecting the whole workspace. Those checks caught a bad copy & paste in
Ticks
, plus a variety of other odds & ends across the project.I've disabled some of the more spammy warnings for now, and fixed the easily fixable -- what's left is: