Add a way to get all unique and virtual accounts from the economy service #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImMorpheus
added
system: economy
api: 8 (u)
ImMorpheus
requested review from
Deamon5550,
Faithcaio,
gabizou,
kashike,
stephan-gh and
Zidane
as code owners
ImMorpheus
changed the title
Zidane
reviewed
Jul 4, 2020
| * | ||
| * @return A {@link Stream} of all stored {@link UniqueAccount} objects. | ||
| */ | ||
| Stream<UniqueAccount> uniqueAccounts(); |
There was a problem hiding this comment.
Add Stream and Collection getters.
I like Streams but we should not shoehorn people into doing them as a default. I made the same change for the CatalogRegistry.
There was a problem hiding this comment.
Maybe also use the same phrasing in the CatalogRegistry that I've seen in other libraries?
There was a problem hiding this comment.
@ImMorpheus I meant the method names.
This was referenced Jan 9, 2022
build: Update dependency org.spongepowered:spongeapi to v8
IntellectualSites/FastAsyncWorldEdit#1531
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1398