Wip/vault-core-2 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7888f5a.
YashP16
requested changes
Jun 22, 2023
Now rebase is triggered on VaultCore
YashP16
requested changes
Jun 26, 2023
YashP16
reviewed
Jun 26, 2023
1. RebaseManager.fetchRebaseAmt() now does not trigger Dripper's collect() when the rebase is skipped 2. Assume USDs token contract is using an aggregated rebase() function 3. VaultCore.mintView() now returns 0 when downside peg check fails 4. Add the missing approval in VaultCore.allocate() 5. Other minor improvements
* Add natspec documentations * Simplify mint and redeem function flow, resolve redundant function calls. * Store collateral conversion factor at the time of adding collateral. * Get strategy withdraw amount in redeemView()
…ilitator role * Skip fee collection for facilitator role * Send relevant mint and redeem information for calculating fee * Reorder functions
* Make contract non-upgradeable * Add recoverERC20 function * Add nat-spec comments
* Add nat-spec comments * Rename variables
YashP16
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VaultCorebased on feedback from the previous PRRebaseManagerandDripperRebaseManagernow skips rebase when the apr is too lowVaultCoreisValidStrategyfunction inCollateralManagerIStrategy