Audit Fixes QS-3 #37
Merged
Audit Fixes QS-3 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed VSTOracle.sol * Removed all tests/configurations related with VST token
bayou020
requested review from
YashP16,
TechnoGeek01,
parv3213 and
arcantheon
There was a problem hiding this comment.
Hey @bayou020, the brownie scripts still contain VST related data. Do we need them?
|
@TechnoGeek01 i don't think that we need brownie test files since we are working on foundry. @YashP16 shall we remove those files ? |
I think these brownie files are deployment files not test files. |
* Removed VST from Brownie deployement scripts
parv3213
approved these changes
Nov 25, 2023
* (MasterPriceOracle.t.sol) Removed Unnecessary Comment
YashP16
requested changes
Nov 28, 2023
| @@ -29,26 +28,27 @@ def main(): | |||
| chainlink_oracle = ChainlinkOracle.deploy( | |||
| chainlink_feeds, {"from": user}, publish_source=True | |||
| ) | |||
There was a problem hiding this comment.
Something wrong with formatting @bayou020.
please use Black formatter in vs-code for consistency
* (deploy_oracles.py) Fixed Formatting issue.
YashP16
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Team's request on SPE-3