Add UniswapV3 strategy #26
Conversation
Fix bug Co-authored-by: arcantheon <140178288+arcantheon@users.noreply.github.com>
- As safeApprove reverts if allowance is not 0
1. Move nfpm, uniV3Factory and lpTokenId to UniswapPoolData 2. Remove setPTokenAddress and removePToken 3. Calling _setPTokenAddress inside initialize 4. Had to make `poolData` inside `allocate` as storage because updating `lpTokenId`
This comment was marked as outdated.
This comment was marked as outdated.
|
Stack-too-deep error persists. As at two places we are using- And running this line itself throws a stack-too-deep. |
| /// @notice Allocates deposited assets into the Uniswap V3 pool to provide liquidity. | ||
| /// @param _amounts An array containing the amounts of tokens to be allocated. | ||
| /// @param _minMintAmt An array specifying the minimum minting amounts for each token. | ||
| function allocate(uint256[2] calldata _amounts, uint256[2] calldata _minMintAmt) external onlyOwner nonReentrant { |
There was a problem hiding this comment.
Calculate minMintAmt inside the function rather than accepting it.
Make use of depositSlippage
minAmount = amount - amount * depositSlippage / Helpers.MAX_PERCENTAGE;
There was a problem hiding this comment.
Yeah makes sense. We can do this.
| /// @notice Redeems a specified amount of liquidity from the Uniswap V3 pool. | ||
| /// @param _liquidity The amount of liquidity to redeem. | ||
| /// @param _minBurnAmt An array specifying the minimum burn amounts for each token. | ||
| function redeem(uint256 _liquidity, uint256[2] calldata _minBurnAmt) external onlyOwner nonReentrant { |
There was a problem hiding this comment.
variable name _minBurnAmt is not relevant with it's actual meaning. Consider renaming it with _minAmountOut
| } | ||
|
|
||
| /// @inheritdoc InitializableAbstractStrategy | ||
| /// @dev Calls checkBalance internally as the Uniswap V3 pools does not lock the deposited assets. |
There was a problem hiding this comment.
Does not call checkBalance internally, kindly update the doc
getAmountsForLiquidity function.
|
|
||
| /// @notice Redeems a specified amount of liquidity from the Uniswap V3 pool. | ||
| /// @param _liquidity The amount of liquidity to redeem. | ||
| /// @param _minAmountOut An array specifying the minimum burn amounts for each token. |
There was a problem hiding this comment.
Update code doc, it still refers to burn amounts
|
This file has some TODO text, please do not merge yet. I will remove the TODOs after the review. |
I have added TODO in places that require higher focus for review. I will remove them ASAP.