Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mkdir exception #4041

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

iftaras
Copy link
Contributor

@iftaras iftaras commented Nov 29, 2023

Add a third flag to the mkdir function to allow it to create root folder if they are not present

1️⃣ Why should it be added? What are the benefits of this change?
Because if the cache folder is not present inside the storage/framework path then the script throws an unhandled exception and does not create the necessary folders

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No

3️⃣ Does it include tests, if possible?
Not required

4️⃣ Any drawbacks? Possible breaking changes?
No

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.

6️⃣ Thanks for contributing! 🙌

Add a third flag to the `mkdir` function to allow it to create root folder if they are not present
@patrickbrouwers patrickbrouwers merged commit 7d6735d into SpartnerNL:3.1 Dec 8, 2023
16 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants