Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added callback binding for InputText #156

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Added callback binding for InputText #156

merged 6 commits into from
Feb 7, 2023

Conversation

moheng233
Copy link
Contributor

#73

@SpaiR
Copy link
Owner

SpaiR commented Feb 5, 2023

@moheng233 Good first PR!
Can I ask you to remove the latest commit (the one with [ci skip]). Github can't run checks for it.

@moheng233
Copy link
Contributor Author

Yes, I have deleted it now.

@moheng233 moheng233 closed this Feb 5, 2023
@moheng233 moheng233 reopened this Feb 5, 2023
@moheng233 moheng233 closed this Feb 5, 2023
@SpaiR
Copy link
Owner

SpaiR commented Feb 5, 2023

I see you have some troubles. Keep PR opened, I'll fix them by myself 😉

- Extended example;
- Added input text callback ImGuiInputTextFlags#CallbackEdit;
- Minor code improvements.
@SpaiR SpaiR force-pushed the main branch 2 times, most recently from 11a6a40 to 466145e Compare February 7, 2023 11:12
@SpaiR SpaiR merged commit 986aa53 into SpaiR:main Feb 7, 2023
@SpaiR
Copy link
Owner

SpaiR commented Feb 7, 2023

I've merged PR with some commits from my side. In general, everything looks good. Thank you!

@moheng233
Copy link
Contributor Author

Thank you so much。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants