Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calcTextSize to be used in a static context #143

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

davfsa
Copy link
Contributor

@davfsa davfsa commented Nov 14, 2022

Description

calcTextSize was missing the static keyword. I also removed the final one because it seems inconsistent with the rest of methods

Type of change

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@davfsa
Copy link
Contributor Author

davfsa commented Nov 14, 2022

@SpaiR would it also be possible to create a release after this is merged?

Thanks!

@SpaiR SpaiR added the fix Fixes problems label Nov 16, 2022
@SpaiR
Copy link
Owner

SpaiR commented Nov 16, 2022

@davfsa Thanks for the contribution!
I think it is possible to create release on the weekend.

@SpaiR SpaiR merged commit 72e0616 into SpaiR:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants