Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example] Add example of Canva Editor #126

Merged
merged 4 commits into from
May 5, 2022
Merged

Conversation

davidalmarinho
Copy link
Contributor

@davidalmarinho davidalmarinho commented Apr 27, 2022

Description

Add a new example, a canvas editor.
In a project that I am working on it, I spent some hours replicating the canvas editor of imgui example demo window in java because have to read cpp code since have to use List intestead of ImVector<>. So, I think that is a example that is worth it having in this repo.

Fixes # (issue)
No fixes.

Type of change

Please check options that are relevant.

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
    Didn't add tests, but tested the code and it is working properly.
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SpaiR SpaiR added the enhancement New feature or request label Apr 29, 2022
Copy link
Owner

@SpaiR SpaiR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidalmarinho Thank you for the contribution!

I've made some notices about the code. Please, address them to proceed. Also, would you kindly to rebase your branch to the latest main? That is required to launch CI checks.

example/src/main/java/ExampleCanvaEditor.java Outdated Show resolved Hide resolved
example/src/main/java/ExampleCanvaEditor.java Outdated Show resolved Hide resolved
example/src/main/java/ExampleCanvaEditor.java Outdated Show resolved Hide resolved
example/src/main/java/Extra.java Outdated Show resolved Hide resolved
davidalmarinho added a commit to davidalmarinho/imgui-java that referenced this pull request Apr 29, 2022
@davidalmarinho
Copy link
Contributor Author

You are welcome!
I think that now is all corrected.
If you need something else let me know :)

example/src/main/java/Main.java Outdated Show resolved Hide resolved
@SpaiR SpaiR merged commit 3a494ba into SpaiR:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants