Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust module name depending on deploy type #122

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Conversation

tmvkrpxl0
Copy link
Contributor

@tmvkrpxl0 tmvkrpxl0 commented Mar 11, 2022

Description

Changes module name depending on deploy type, this is workaround for Minecraft forge not being able to load multiple native libs, as it cannot load 2 or more modules with same module name

Fixes #118

Type of change

Please check options that are relevant.

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SpaiR SpaiR added the fix Fixes problems label Mar 11, 2022
imgui-binding-natives/build.gradle Outdated Show resolved Hide resolved
imgui-binding-natives/build.gradle Outdated Show resolved Hide resolved
imgui-binding-natives/build.gradle Outdated Show resolved Hide resolved
imgui-binding-natives/build.gradle Outdated Show resolved Hide resolved
@SpaiR SpaiR merged commit 3cd0eeb into SpaiR:main Mar 11, 2022
@tmvkrpxl0
Copy link
Contributor Author

oof, forgot to use ' instead of "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to add multiple native libs
2 participants