Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory editor extension #110

Merged
merged 6 commits into from
Feb 2, 2022
Merged

Memory editor extension #110

merged 6 commits into from
Feb 2, 2022

Conversation

tlf30
Copy link
Contributor

@tlf30 tlf30 commented Jan 28, 2022

This is a set of bindings for the extension: https://github.com/ocornut/imgui_club.
Requested in #109

Please let me know what you think. I would like some feedback on the naming. The repo that contains this extension is ImGui Club, but the actual extension is MemoryEditor. At one point club contained more than just this extension, but those gradually went elsewhere (I think into the main imgui repo). Because of this I made the classpath .club. Please let me know if you would like anything renamed and I will do so.

Please let me know if you have any other feedback as well.

@FlorianMichael please comment if this implementation will work for you. See the example app for how to use.

Thanks,
Trevor

image

@SpaiR
Copy link
Owner

SpaiR commented Jan 28, 2022

image The Implementation is always crashing if i click on the combo box in the example

Because you need to compile binaries for it. To test things locally go to the CI artifacts and put them to the bin folder. https://github.com/SpaiR/imgui-java/actions/runs/1759323591

@FlorianMichael
Copy link

thanks

@SpaiR SpaiR added 3rd party Everything out of the Dear ImGui scope api Connected with imgui-java API enhancement New feature or request labels Jan 29, 2022
@SpaiR
Copy link
Owner

SpaiR commented Jan 29, 2022

@tlf30 Great job!

Speaking about the naming. I would probably prefer something like memedit or else instead of just a club. It doesn't seem like imgui_club will have any additional stuff. Highly likely at some point it will be renamed. So it's better to have more meaningful name from the start.

@FlorianMichael
Copy link

I mean you could also call the package club.memoryeditor

@tlf30
Copy link
Contributor Author

tlf30 commented Jan 30, 2022

@SpaiR how does that look? Anything else you want changed?

@SpaiR
Copy link
Owner

SpaiR commented Jan 31, 2022

@tlf30 I assume you want to change .h/.cpp files too. 😅

@tlf30
Copy link
Contributor Author

tlf30 commented Jan 31, 2022

I had forgot the header, sorry I was so focused on the classpath 🤦
Do you also want the submodule renamed, or kept as the default repo name?

@SpaiR
Copy link
Owner

SpaiR commented Feb 2, 2022

Everything else looks good for me. Good stuff!

@SpaiR SpaiR merged commit fefac80 into SpaiR:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Everything out of the Dear ImGui scope api Connected with imgui-java API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants