Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arbitrary feature to sov-db #853

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

vlopes11
Copy link
Contributor

This commit introduces arbitrary derive for the types defined in sov-db.

It also introduces a fallible wrapper for proptest, that expects the types to be infallible. However, the database is created on disk; given the fallible nature of I/O, they must also be subject to fail.

OTOH, a disk write failure is not a logical bug of the SDK, so maybe it would be ok to panic. This could however be inconvenient, as any fuzzing process would be interrupted by such panic.

This commit introduces arbitrary derive for the types defined in sov-db.

It also introduces a fallible wrapper for proptest, that expects the
types to be infallible. However, the database is created on disk; given
the fallible nature of I/O, they must also be subject to fail.

OTOH, a disk write failure is not a logical bug of the SDK, so maybe it
would be ok to panic. This could however be inconvenient, as any fuzzing
process would be interrupted by such panic.
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #853 (1d30b55) into nightly (e8f32b7) will decrease coverage by 0.2%.
The diff coverage is 100.0%.

❗ Current head 1d30b55 differs from pull request most recent head 5410778. Consider uploading reports for the commit 5410778 to get more accurate results

Files Changed Coverage Δ
full-node/db/sov-db/src/schema/types.rs 80.7% <ø> (ø)
full-node/db/sov-db/src/ledger_db/mod.rs 91.5% <100.0%> (ø)
full-node/db/sov-db/src/native_db.rs 100.0% <100.0%> (ø)
full-node/db/sov-db/src/state_db.rs 90.6% <100.0%> (ø)

... and 81 files with indirect coverage changes

@vlopes11 vlopes11 added this pull request to the merge queue Sep 18, 2023
Merged via the queue into nightly with commit ff1770e Sep 18, 2023
12 checks passed
@vlopes11 vlopes11 deleted the vlopes11/feature/sov-db-arbitrary branch September 18, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants