Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend sov- prefix to all releasable crates #824

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Sep 8, 2023

Fixes #819.

Signed-off-by: Filippo Costa <filippo@sovlabs.io>
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
Signed-off-by: Filippo Costa <filippo@sovlabs.io>
@neysofu neysofu changed the title Prepend sov- prefix to all releasable crates. Prepend sov- prefix to all releasable crates Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #824 (31623d0) into nightly (44db227) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Files Changed Coverage Δ
adapters/celestia/src/verifier/mod.rs 0.0% <ø> (ø)
adapters/risc0/src/host.rs 0.0% <ø> (ø)
...mplementations/sov-sequencer-registry/src/hooks.rs 100.0% <ø> (ø)
module-system/sov-modules-api/src/transaction.rs 100.0% <ø> (ø)
...ystem/sov-modules-stf-template/src/app_template.rs 89.0% <ø> (ø)
module-system/sov-modules-stf-template/src/lib.rs 83.6% <ø> (ø)
module-system/sov-state/src/zk_storage.rs 53.8% <ø> (ø)
full-node/sov-stf-runner/src/config.rs 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

Copy link
Member

@bkolad bkolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, question do we need to change any docs in readmes?

@neysofu
Copy link
Member Author

neysofu commented Sep 8, 2023

@bkolad I modified the docs wherever I could find references to the old names – I wouldn't be surprised if I missed some though, I'll check again before merging.

@neysofu neysofu added this pull request to the merge queue Sep 8, 2023
Merged via the queue into nightly with commit b735eaf Sep 8, 2023
12 checks passed
@neysofu neysofu deleted the filippo/rename-crates branch September 8, 2023 13:12
neysofu added a commit that referenced this pull request Sep 14, 2023
* celestia -> sov-celestia-adapter in manifests & docs

Signed-off-by: Filippo Costa <filippo@sovlabs.io>

* celestia -> sov-celestia-adapter in *.rs

Signed-off-by: Filippo Costa <filippo@sovlabs.io>

* risc0-adapter -> sov-risc0-adapter

Signed-off-by: Filippo Costa <filippo@sovlabs.io>

* Fix Celestia rename

* Rename zk-cycle-utils/macros

* cargo fmt --all

---------

Signed-off-by: Filippo Costa <filippo@sovlabs.io>
neysofu added a commit that referenced this pull request Sep 14, 2023
* celestia -> sov-celestia-adapter in manifests & docs

Signed-off-by: Filippo Costa <filippo@sovlabs.io>

* celestia -> sov-celestia-adapter in *.rs

Signed-off-by: Filippo Costa <filippo@sovlabs.io>

* risc0-adapter -> sov-risc0-adapter

Signed-off-by: Filippo Costa <filippo@sovlabs.io>

* Fix Celestia rename

* Rename zk-cycle-utils/macros

* cargo fmt --all

---------

Signed-off-by: Filippo Costa <filippo@sovlabs.io>
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
* celestia -> sov-celestia-adapter in manifests & docs

Signed-off-by: Filippo Costa <filippo@sovlabs.io>

* celestia -> sov-celestia-adapter in *.rs

Signed-off-by: Filippo Costa <filippo@sovlabs.io>

* risc0-adapter -> sov-risc0-adapter

Signed-off-by: Filippo Costa <filippo@sovlabs.io>

* Fix Celestia rename

* Rename zk-cycle-utils/macros

* cargo fmt --all

---------

Signed-off-by: Filippo Costa <filippo@sovlabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename crates to avoid name conflicts when publishing to https://crates.io
2 participants