Add missing derive(serde..) to BcsCodec & JsonCodec
#823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 1 file with indirect coverage changes 📢 Have feedback on the report? Share it here. |
LukaszRozmej
approved these changes
Sep 8, 2023
neysofu
pushed a commit
that referenced
this pull request
Sep 14, 2023
Add risc0-adapter to packages_to_publish.txt Signed-off-by: Filippo Costa <filippo@sovlabs.io> Allow modules to query token names (#821) * Add public function for fetching token names * Add test coverage * lint fix keypair/private_key discrepancy for sov-cli (#811) * fix keypair/private_key discrepancy * formatting * changes to use consistent format * README changes * linting fixes * remove checked in rollup_config.toml * fix token address in git workflow --------- Co-authored-by: dubbelosix <dub@006.com> Initializes pending block on begin slot + genesis block (#803) * Initialize pending_block in begin_slot_hook properly * add timestamp handling * simplify unwrap * simplify basefee calculation, genesis block will be handled in genesis * Initialize genesis block * improvements * fix tests * add tests * fix test * Add expect * Move to lazy_static global test_config * simplify * fix * one more fix Add missing derive to BcsCodec (#823) Bug fix: StateMap::Keys are not consistent across platforms (#804) * Bug fix: Introduce EncodeLike trait. This PR removes our StateMap key encoding based on std::Hash, which was not consistent across platforms. Instead, this PR introduces the `EncodeLike<Ref, Target>` trait which marks that Ref can be encoded like Target by the implementing codec. This PR also removes the SingletonKey type, which required special handling in codecs. Instead, of using this placeholder, this PR implements auxiliary methods on the working set for dealing with singletons * Remove rollup config changes * fix test: qualify conversion * Add missing bounds for fuzzing * fix docs * clarify zsts in comment * allow separate codecs for keys/values * Split key and value codecs * Fix fuzzing feature * Introduce StateCodec trait to allow EncodeLike with SplitCodec * add doc comments * Fix fuzz and test targets * Fix test * fix docs Fix Cargo.lock, packages_to_publish.txt Signed-off-by: Filippo Costa <filippo@sovlabs.io> Update Cargo.lock Signed-off-by: Filippo Costa <filippo@sovlabs.io> Update Cargo.lock Signed-off-by: Filippo Costa <filippo@sovlabs.io>
neysofu
pushed a commit
that referenced
this pull request
Sep 14, 2023
Add risc0-adapter to packages_to_publish.txt Signed-off-by: Filippo Costa <filippo@sovlabs.io> Allow modules to query token names (#821) * Add public function for fetching token names * Add test coverage * lint fix keypair/private_key discrepancy for sov-cli (#811) * fix keypair/private_key discrepancy * formatting * changes to use consistent format * README changes * linting fixes * remove checked in rollup_config.toml * fix token address in git workflow --------- Co-authored-by: dubbelosix <dub@006.com> Initializes pending block on begin slot + genesis block (#803) * Initialize pending_block in begin_slot_hook properly * add timestamp handling * simplify unwrap * simplify basefee calculation, genesis block will be handled in genesis * Initialize genesis block * improvements * fix tests * add tests * fix test * Add expect * Move to lazy_static global test_config * simplify * fix * one more fix Add missing derive to BcsCodec (#823) Bug fix: StateMap::Keys are not consistent across platforms (#804) * Bug fix: Introduce EncodeLike trait. This PR removes our StateMap key encoding based on std::Hash, which was not consistent across platforms. Instead, this PR introduces the `EncodeLike<Ref, Target>` trait which marks that Ref can be encoded like Target by the implementing codec. This PR also removes the SingletonKey type, which required special handling in codecs. Instead, of using this placeholder, this PR implements auxiliary methods on the working set for dealing with singletons * Remove rollup config changes * fix test: qualify conversion * Add missing bounds for fuzzing * fix docs * clarify zsts in comment * allow separate codecs for keys/values * Split key and value codecs * Fix fuzzing feature * Introduce StateCodec trait to allow EncodeLike with SplitCodec * add doc comments * Fix fuzz and test targets * Fix test * fix docs Fix Cargo.lock, packages_to_publish.txt Signed-off-by: Filippo Costa <filippo@sovlabs.io> Update Cargo.lock Signed-off-by: Filippo Costa <filippo@sovlabs.io> Update Cargo.lock Signed-off-by: Filippo Costa <filippo@sovlabs.io>
preston-evans98
pushed a commit
that referenced
this pull request
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing serde derive for
BcsCodec & JsonCodecTesting
Ci passes.
Docs
No doc changes.