Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly CI pre-release check #818

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Weekly CI pre-release check #818

merged 4 commits into from
Sep 15, 2023

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Sep 7, 2023

Description

cargo publish --dry-run doesn't benefit from caching and tends to be quite fragile, so it's a poor candidate for CI. There's one specific check that we'd like to run periodically, though: whether a crate can't be released because we haven't properly specified its dependencies' versions.

@neysofu
Copy link
Member Author

neysofu commented Sep 7, 2023

This check currently fails on nightly, fix is in #817.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #818 (1fe6f58) into nightly (27db0d2) will increase coverage by 2.0%.
Report is 3 commits behind head on nightly.
The diff coverage is n/a.

see 20 files with indirect coverage changes

Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two optional discussions

.github/workflows/check_missing_dependency_versions.yml Outdated Show resolved Hide resolved
.github/workflows/check_missing_dependency_versions.yml Outdated Show resolved Hide resolved
@neysofu
Copy link
Member Author

neysofu commented Sep 13, 2023

Blocked by #817.

Signed-off-by: Filippo Costa <filippo@sovlabs.io>
@neysofu neysofu added this pull request to the merge queue Sep 15, 2023
Merged via the queue into nightly with commit c2206ff Sep 15, 2023
14 checks passed
@neysofu neysofu deleted the filippo/weekly-release-check branch September 15, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants