Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Rust in CI with rustup show, not from setup-rust-toolchain@v1 #604

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Install Rust in CI with rustup show, not from setup-rust-toolchain@v1 #604

merged 1 commit into from
Aug 1, 2023

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Aug 1, 2023

It turns out actions-rust-lang/setup-rust-toolchain@v1 tries to set up its own caching logic, which may clash with ours.

@neysofu neysofu requested a review from dubbelosix August 1, 2023 16:10
@neysofu neysofu marked this pull request as ready for review August 1, 2023 16:10
@neysofu neysofu enabled auto-merge (squash) August 1, 2023 16:13
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #604 (e5e0c53) into nightly (9d7b3d2) will decrease coverage by 0.1%.
The diff coverage is n/a.

see 1 file with indirect coverage changes

@neysofu neysofu merged commit baf2687 into nightly Aug 1, 2023
12 checks passed
@neysofu neysofu deleted the filippo/install-rust-ci branch August 1, 2023 17:03
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
@neysofu @preston-evans98
Switch away from setup-rust-toolchain@v1 (#604)
e981cc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen-stig citizen-stig citizen-stig approved these changes

@dubbelosix dubbelosix Awaiting requested review from dubbelosix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neysofu @citizen-stig