Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: remove anvil-core dependency and use types from reth instead. #574

Merged
merged 6 commits into from
Jul 28, 2023
Merged

EVM: remove anvil-core dependency and use types from reth instead. #574

merged 6 commits into from
Jul 28, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Jul 27, 2023 •
edited
Loading

Description

This PR introduces the following changes:

  1. Eliminates dependencies on anvil-core.
  2. Introduces relevant types from reth.

As a result of these changes, the sendRawTransaction and ethCall APIs now operate with reth types. This modification will enable us to reuse reth logic in our EVM module in the future.

Linked Issues

Testing

No changes.

Docs

No changes.

@bkolad bkolad changed the title WIP: Move EVM to reth types Move EVM to reth types Jul 28, 2023
@bkolad bkolad changed the title Move EVM to reth types EVM: remove anvil-core dependency and use types from reth instead. Jul 28, 2023
@bkolad bkolad marked this pull request as ready for review July 28, 2023 13:10
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #574 (6e99fbf) into nightly (80b2518) will decrease coverage by 0.1%.
The diff coverage is n/a.

see 29 files with indirect coverage changes

@bkolad bkolad merged commit 681b7a5 into nightly Jul 28, 2023
13 checks passed
@bkolad bkolad deleted the blaze/evm_reth_types branch July 28, 2023 15:14
@neysofu neysofu mentioned this pull request Aug 21, 2023
Closed
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
@bkolad @preston-evans98
EVM: remove anvil-core dependency and use types from reth instead. (
d1e35be 
#574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preston-evans98 preston-evans98 preston-evans98 approved these changes

@citizen-stig citizen-stig Awaiting requested review from citizen-stig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVM: Replace anvil-core types with types from reth.
2 participants
@bkolad @preston-evans98