Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-anonymizing BlobTransactionTrait in STF #500

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

citizen-stig
Copy link
Member

@citizen-stig citizen-stig commented Jul 17, 2023

Description

Currently STF has anonymous BlobTransactionTrait:

pub trait StateTransitionFunction<Vm: Zkvm> {
  // ...
  
      fn apply_blob(
        &mut self,
        blob: &mut impl BlobTransactionTrait,
        misbehavior_hint: Option<Self::MisbehaviorProof>,
    ) -> BatchReceipt<Self::BatchReceiptContents, Self::TxReceiptContents>;
}

In order to solve #465 , this trait needs to be de-anonymized, so then Address associated type can be linked to BatchReceiptContent or other enums that need it.

This PR is first step towards this change, by bringing this trait to trait definition of STF

Linked Issues

Testing

All automated tests have passed

Docs

No change in the documentation, since change is only cosmetical.

@citizen-stig citizen-stig changed the title De-anonymizing blobtrait De-anonymizing BlobTransactionTrait in STF Jul 17, 2023
@citizen-stig citizen-stig force-pushed the chores/deanonimize_blob_transaction_trait branch from b2ab87f to e3c8548 Compare July 17, 2023 12:31
@citizen-stig citizen-stig marked this pull request as ready for review July 17, 2023 12:40
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #500 (4e0cd40) into nightly (11c6eb3) will increase coverage by 0.0%.
The diff coverage is 75.0%.

Impacted Files Coverage Δ
module-system/sov-modules-api/src/encode.rs 0.0% <0.0%> (ø)
rollup-interface/src/state_machine/stf.rs 80.0% <ø> (ø)
...ystem/sov-modules-stf-template/src/app_template.rs 82.7% <100.0%> (+<0.1%) ⬆️
module-system/sov-modules-stf-template/src/lib.rs 97.4% <100.0%> (ø)

@citizen-stig citizen-stig merged commit 843c79d into nightly Jul 18, 2023
10 checks passed
@citizen-stig citizen-stig deleted the chores/deanonimize_blob_transaction_trait branch July 18, 2023 09:24
citizen-stig added a commit that referenced this pull request Jul 20, 2023
* De-anonymizing blobtrait
* Consistency with import
preston-evans98 pushed a commit that referenced this pull request Sep 14, 2023
* De-anonymizing blobtrait
* Consistency with import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SequencerOutcome should have generic over address trait for better logging
2 participants