-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-anonymizing BlobTransactionTrait in STF #500
Merged
citizen-stig
merged 5 commits into
nightly
from
chores/deanonimize_blob_transaction_trait
Jul 18, 2023
Merged
De-anonymizing BlobTransactionTrait in STF #500
citizen-stig
merged 5 commits into
nightly
from
chores/deanonimize_blob_transaction_trait
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizen-stig
changed the title
De-anonymizing blobtrait
De-anonymizing BlobTransactionTrait in STF
Jul 17, 2023
citizen-stig
force-pushed
the
chores/deanonimize_blob_transaction_trait
branch
from
July 17, 2023 12:31
b2ab87f
to
e3c8548
Compare
Codecov Report
|
bkolad
reviewed
Jul 17, 2023
bkolad
approved these changes
Jul 18, 2023
citizen-stig
added a commit
that referenced
this pull request
Jul 20, 2023
* De-anonymizing blobtrait * Consistency with import
preston-evans98
pushed a commit
that referenced
this pull request
Sep 14, 2023
* De-anonymizing blobtrait * Consistency with import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently STF has anonymous
BlobTransactionTrait
:In order to solve #465 , this trait needs to be de-anonymized, so then
Address
associated type can be linked toBatchReceiptContent
or other enums that need it.This PR is first step towards this change, by bringing this trait to trait definition of STF
Linked Issues
SequencerOutcome
should have generic over address trait for better logging #465Testing
All automated tests have passed
Docs
No change in the documentation, since change is only cosmetical.