-
-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbnail Zoom Option #2435
Thumbnail Zoom Option #2435
Conversation
Also @SoftFever, this will likely have merge conflicts with #2405. When you merge that, I should be able to resolve the conflicts pretty quickly |
Hi @Ocraftyone |
# Conflicts: # src/libslic3r/GCode.cpp # src/libslic3r/Preset.cpp # src/libslic3r/PrintConfig.cpp # src/slic3r/GUI/Tab.cpp
96072d0
to
b056d72
Compare
For most users this is absolutely true, but as @Ocraftyone already mentioned this is very helpful if you have only a small screen. Hope you don't mind implementing this. 🥺 thanks in advance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can reduce the margin from 20% to 10% by reduce the factor from 0.1 to 0.05 in Ln5567 - Ln5572
Hi @Ocraftyone @discip I'd also like to highlight that setting a zoom factor could lead to parts of the model being cropped in the thumbnail, depending on its geometric shape. We calculate the camera view based on the model's Axis-Aligned Bounding Box (AABB) rather than the tight bounding box in ISO view. Computing the latter requires more processing power and, in my opinion, isn't essential. This approach is why some models appear slightly smaller while others seem just right. Currently, the thumbnail zooms to 20% larger than the actual bounding box of the model. We could reduce this to 10%, ensuring there's still a reasonable margin, which might benefit those using smaller screens. (refer to my comment in the code review view) I hope you can understand my considerations. |
@SoftFever Just one more thought: Would it be too difficult to set the general zoom to fit the object based not on its bounding box but on the widest dimension (whether horizontal or vertical)? This one for example should be fittet based on the vertical dimensions. And this one should be fittet based on the horizontal dimensions. Or would that already mean the consumption of additional computing power? |
Are you saying more of a post processing to the image? |
No, I mean adjusting the 'position of the camera' in relation to the object. Post processing the image will decrease the quality of the image. |
|
Alright, besides proposing to reworking the zoom 'mechanics' I unfortunately have no idea how this could be achieved efficiently. |
Closing in favor of a different approach |
@Ocraftyone What exactly is the other approach? |
I believe the other approach would be to increase the default zoom like SoftFever mentioned. I plan to get around to this and finish looking into the BTT stuff when I am done with my project. I am currently working on updating wxwidgets and implementing using bitmap bundles. |
Thanks for the update. Although I'm super curious to see the final result, there is absolutely no intention to push. Thank you very much in advance! 👍🏻 |
Allows the user to specify if they would like to zoom in/out the thumbnail. While working on #2405, I had requests for this as small thumbnails on small screens were hard to see. This will allow more flexability for those edge cases while leaving other UX alone.