Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosserat extension refactoring 2 #111

Merged
merged 26 commits into from
Jun 26, 2024
Merged

Cosserat extension refactoring 2 #111

merged 26 commits into from
Jun 26, 2024

Commits on Jun 11, 2024

  1. Rename BaseCosserat into BaseCosseratMapping

    @damienmarchal
    damienmarchal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bef4478 View commit details
    Browse the repository at this point in the history

  2. Rename BaseCosserat files into BaseCosseratMapping

    @damienmarchal
    damienmarchal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6b170ea View commit details
    Browse the repository at this point in the history

  3. Refactor the code so that BaseCosseratMapping is the base class of Co… 

    …sseratMapping
    @damienmarchal
    damienmarchal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    15f6037 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Add a Cosserat/fwd.h file to declare new types in Cosserat plugin 

    Put in this fwd.h file all forward declaration of c++ types.
In our case this is where we will declare the SE3 from Matrix4.
    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    6f463c9 View commit details
    Browse the repository at this point in the history

  2. Move SE3, se3, _SE3, _se3 out of the class.

    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    87a30a7 View commit details
    Browse the repository at this point in the history

  3. FIXUP

    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    18d8335 View commit details
    Browse the repository at this point in the history

  4. Add a types.h file to factorize all types declaration in cosserat plu… 

    …gins
    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3e73639 View commit details
    Browse the repository at this point in the history

  5. Add a comment in BaseCOsseratMapping.

    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    dc496d8 View commit details
    Browse the repository at this point in the history

  6. Replace Matrix3 by Mat3x3 and Matrix4 by Mat4x4.

    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    837c3bf View commit details
    Browse the repository at this point in the history

  7. Replace if(d_debug) msg_info("YOLO") by msg_info() 

    Because msg_info already contains a test on wether we should print a message and this
is connected by the printLog data field.

More generally "debug" datafield is questionnable.
    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f4b88f2 View commit details
    Browse the repository at this point in the history

  8. Replace ReadAccessor with sofa::helper::getReadAccessor; 

    The sofa::helper::getReadAccessor function is to be used on type free expression this way:
auto a = getReadAccessor(m_data);
    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9aa7ac6 View commit details
    Browse the repository at this point in the history

  9. remove toModel, fromModel1, fromModel2 to use he inherited attributes… 

    … from MultiMapping
    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    077e984 View commit details
    Browse the repository at this point in the history

  10. Several cleaning BaseCosseratMapping

    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    2d44aef View commit details
    Browse the repository at this point in the history

  11. Clean Vec6,Mat4x4 usage in BaseCosseratMapping for more readability (… 

    …should't be breaking)
    @damienmarchal
    damienmarchal committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e7392fe View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Cosmetic cleaning in BaseCosserat & DiscreteCorreseratMapping.h

    @damienmarchal
    damienmarchal committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ee8b742 View commit details
    Browse the repository at this point in the history

  2. Removes un-needed includes in BaseCosseratMapping.h

    @damienmarchal
    damienmarchal committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    293f3d7 View commit details
    Browse the repository at this point in the history

  3. Factorize toModel, fromModel1, fromModel2 in BaseCosseratMapping

    @damienmarchal
    damienmarchal committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    6a6f10d View commit details
    Browse the repository at this point in the history

  4. Refactor the init() between BaseCosseratMapping & its child classes (… 

    …breaking)
    @damienmarchal
    damienmarchal committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0059942 View commit details
    Browse the repository at this point in the history

  5. Factorize initialization in BaseCosseratMapping.

    @damienmarchal
    damienmarchal committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    bda1ff1 View commit details
    Browse the repository at this point in the history

  6. FIXUP initialization.

    @damienmarchal
    damienmarchal committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    334cf6b View commit details
    Browse the repository at this point in the history

  7. Factorizing in init funciton.

    @damienmarchal
    damienmarchal committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    aa20251 View commit details
    Browse the repository at this point in the history

  8. Types declaration in BaseCosseratMapping removed.

    @damienmarchal
    damienmarchal committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    60446a5 View commit details
    Browse the repository at this point in the history

  9. Modernize types declaration in DiscreetCosseratMapping 

    Among other things:
- instead of re-defining a new type in each class, re-using the one defined in
its parent.
- remove useless headers
- remove type declaration that does not seems to be needed.
    @damienmarchal
    damienmarchal committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    40279f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Refactor computeAdjoint.

    @damienmarchal
    damienmarchal committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b63fb6d View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. add callback function in case we are doing dynamic discretisation of … 

    …cosserat beam
    @adagolodjo
    adagolodjo committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    35dada7 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. mv the initCosserat.h.in file into config.h.in

    @adagolodjo
    adagolodjo committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6eee0d9 View commit details
    Browse the repository at this point in the history