Cosserat extension refactoring 2 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put in this fwd.h file all forward declaration of c++ types. In our case this is where we will declare the SE3 from Matrix4.
Because msg_info already contains a test on wether we should print a message and this is connected by the printLog data field. More generally "debug" datafield is questionnable.
The sofa::helper::getReadAccessor function is to be used on type free expression this way: auto a = getReadAccessor(m_data);
… from MultiMapping
…should't be breaking)
Among other things: - instead of re-defining a new type in each class, re-using the one defined in its parent. - remove useless headers - remove type declaration that does not seems to be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.