Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland-backend: Add getter for global name #735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PolyMeilex
Copy link
Member

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (1f6f4f5) to head (84bfcc0).
Report is 31 commits behind head on master.

Files Patch % Lines
wayland-backend/src/rs/server_impl/handle.rs 0.00% 15 Missing ⚠️
wayland-backend/src/server_api.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   73.11%   78.62%   +5.51%     
==========================================
  Files          45       41       -4     
  Lines        8183     6537    -1646     
==========================================
- Hits         5983     5140     -843     
+ Misses       2200     1397     -803     
Flag Coverage Δ
main ?
test-- 80.84% <0.00%> (?)
test-client_system- 72.03% <0.00%> (?)
test-client_system-server_system ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elinorbgr
Copy link
Member

Given the CI failures, I think this bumps the minimum supported libwayland version. That is not a problem, but the CI scripts should be updated as such, and it should be documented in the changelogs.

@elinorbgr
Copy link
Member

Ok, actually the CI no longer fixes the libwayland version, so there's nothing to update here.

But it looks like this change requires a newer version of libwayland-server than is available on the CI environment...

@PolyMeilex
Copy link
Member Author

@elinorbgr I bumped Ubuntu version to 24.04, and we are green now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants