Map doorlock that doesn't support Power source cluster to lock-lockalarm-nobattery #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 59 files 375 suites 0s ⏱️ For more details on these errors, see this check. Results for commit 9400cee. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9400cee |
HunsupJung
force-pushed
the
feature/lock-nobattery
branch
from
7b7e89d
to
bef1dce
Compare
…arm-nobattery Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
HunsupJung
force-pushed
the
feature/lock-nobattery
branch
from
bef1dce
to
9400cee
Compare
tpmanley
reviewed
Jun 17, 2024
| local battery_eps = device:get_endpoints(clusters.PowerSource.ID, {feature_bitmap = clusters.PowerSource.types.PowerSourceFeature.BATTERY}) | ||
| if #battery_eps == 0 then | ||
| device.log.debug("Device does not support battery. Switching profile.") | ||
| device:try_update_metadata({profile = "lock-lockalarm-nobattery"}) |
There was a problem hiding this comment.
The profile will get changed again if #pins_eps == 0 due to the code just below
There was a problem hiding this comment.
Yes, that is correct. In fact, because of the PR I pushed, there is no possibility of executing the code below at this time. so.. I think below code can be removed from the device_added function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SecuYou releases their Matter supported door lock. securYou Smart Lock. (Link)
This door lock doesn't support Power source cluster and we need to map door lock that doesn't support Power source cluster to lock-lockalarm-nobattery.