Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harman Luxury Change from REST HTTP API to WebSckets #1433

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Harman Luxury Change from REST HTTP API to WebSckets #1433

merged 8 commits into from
Jul 2, 2024

Commits on Jul 2, 2024

  1. remove media presents for MA AVRs 

    Harman decision applied on device and now propagated to SmartThings

Signed-off-by: alon-tchelet <alon.tchelet@streamunlimited.com>
    @alon-tchelet
    alon-tchelet committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    cbac968 View commit details
    Browse the repository at this point in the history

  2. remove keypad input support 

    Harman don't want it and don't plan to use it in the future

Signed-off-by: alon-tchelet <alon.tchelet@streamunlimited.com>
    @alon-tchelet
    alon-tchelet committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    72cc6a5 View commit details
    Browse the repository at this point in the history

  3. add lustre/ws.lua so we can fix small bug in library 

    We are moving the device communications between the hub and the device
to WebSockets.

Until the ST lustre library WebSocket keep_alive ping bug is resolved,
this lustre/ws.lua will be used instead.

Signed-off-by: alon-tchelet <alon.tchelet@streamunlimited.com>
    @alon-tchelet
    alon-tchelet committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ef2c382 View commit details
    Browse the repository at this point in the history

  4. add a specific timeout error handler in REST HTTP reply handler 

    Signed-off-by: alon-tchelet <alon.tchelet@streamunlimited.com>
    @alon-tchelet
    alon-tchelet committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7666603 View commit details
    Browse the repository at this point in the history

  5. delete unused APIs 

    the removed APIs are no longer used after moving to WebSockets

Signed-off-by: alon-tchelet <alon.tchelet@streamunlimited.com>
    @alon-tchelet
    alon-tchelet committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0a35f4b View commit details
    Browse the repository at this point in the history

  6. move credential generation to device side 

    this is done to further match the discovery behaviour to the example
code and to return the handshake process control to the device.

Signed-off-by: alon-tchelet <alon.tchelet@streamunlimited.com>
    @alon-tchelet
    alon-tchelet committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d2467c1 View commit details
    Browse the repository at this point in the history

  7. change communications from REST HTTP API to WebSockets 

    The REST HTTP API polling was creating too much conjunction and was
unreliable at time (especially in weaker networks). Hence, we changed
the whole communication set up between the hub and the device to
WebSockets. With the exception of fetching the device information at
discovery, the rest of the communication is done through a WebSocket.

We implemented a JSON protocol that tries to replicate the native
SmartThings capabilities' table structures and the offline/online logic
is now handled fully by the WebSocket connection status.

Moreover, a lot of old and no longer used functions and namings have
been modified or deleted altogether.

Signed-off-by: alon-tchelet <alon.tchelet@streamunlimited.com>
    @alon-tchelet
    alon-tchelet committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b8073c1 View commit details
    Browse the repository at this point in the history

  8. fix handleReply function documentation 

    Signed-off-by: alon-tchelet <alon.tchelet@streamunlimited.com>
    @alon-tchelet
    alon-tchelet committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a3dc9a6 View commit details
    Browse the repository at this point in the history