Expose bytesused to users
#2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2023 13:32
When capturing JPEG frames, v4l will tell us that the JPEG can be as big as the decoded YUV frame, like 4 MB for a 1080p frame. But typically the JPEG is only 500 KB or so. Exposing bytesused allows callers to copy less data and write precisely-sized JPEG frames
|
Looks like this commit does the same thing? c6925e5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users copy JPEG frames better.
Previously, when you read JPEG frames, it tells you the length of the frame is
size_image, the maximum possible length. So it copies a bunch of zeroes and then if you write them to a file, the file is bigger than the actual JPEG contents.