This repository has been archived by the owner on Jun 14, 2023. It is now read-only.
Add WithSpan #153
Merged
Add WithSpan #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 70.97% 70.83% -0.15%
==========================================
Files 21 21
Lines 982 984 +2
==========================================
Hits 697 697
- Misses 233 235 +2
Partials 52 52
Continue to review full report at Codecov.
|
wu-sheng
reviewed
Mar 2, 2022
| @@ -110,6 +110,14 @@ Get the `activeSpan` in the `Context`. | |||
| go2sky.ActiveSpan(ctx) | |||
| ``` | |||
|
|
|||
| ## With Span | |||
There was a problem hiding this comment.
Could you explain a little more about the use case? Is this span from some other context?
There was a problem hiding this comment.
Like this, need to save the span to multiple context.
wu-sheng
approved these changes
Mar 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.