Ensure jpeg encoder is immutable. #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1779 +/- ##
==========================================
- Coverage 84.49% 84.49% -0.01%
==========================================
Files 849 849
Lines 37252 37251 -1
Branches 4385 4384 -1
==========================================
- Hits 31477 31475 -2
- Misses 4916 4917 +1
Partials 859 859
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
antonfirsov
reviewed
Oct 16, 2021
| /// returns <see langword="null"/> defering the field assignment | ||
| /// to <see cref="InitQuantizationTables(int, JpegMetadata, out Block8x8F, out Block8x8F)"/>. | ||
| /// </summary> | ||
| private static JpegColorType? SetFallbackColorType<TPixel>(Image<TPixel> image) |
There was a problem hiding this comment.
I recommend to rename this to GetFallbackColorType(), since it doesn't change anything.
| JpegMetadata metadata = image.Metadata.GetJpegMetadata(); | ||
| if (IsSupportedColorType(metadata.ColorType)) | ||
| { | ||
| colorType = metadata.ColorType; |
There was a problem hiding this comment.
Nit: we can return metadata.ColorType here, so the indentation with colorType is null becomes unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #1712