Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes two errant references to $context in updateSettingsFile() #6283

Conversation

Sesquipedalian
Copy link
Member

Replaces $context['utf8'] with $utf8 because $context is undefined in updateSettingsFile().

Without this change, updateSettingsFile() could fail to update a setting when the existing value contains non-ASCII characters. This would be a serious problem for most forums that use languages besides English.

Signed-off-by: Jon Stovell <jonstovell@gmail.com>
@Sesquipedalian Sesquipedalian added Language Charset/Encoding UTF8 & mb4 encoding related issues Serious Bug labels Oct 1, 2020
@Sesquipedalian Sesquipedalian requested review from sbulen and removed request for sbulen October 5, 2020 16:20
@Sesquipedalian Sesquipedalian merged commit 523819a into SimpleMachines:release-2.1 Oct 5, 2020
@Sesquipedalian Sesquipedalian deleted the updateSettingsFile_remove_context branch October 5, 2020 23:00
@MissAllSunday MissAllSunday modified the milestone: RC3 Jul 6, 2021
@live627 live627 added Localization Language & internationalization and removed Language labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Charset/Encoding UTF8 & mb4 encoding related issues Localization Language & internationalization Serious Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants