Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Fixes the CI package build step #4399

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

eliknebel
Copy link
Contributor

@eliknebel eliknebel commented Nov 7, 2023

The issue was a typescript related compilation error.

ERROR in /app/assets/src/adaptivity/scripting.ts
./src/adaptivity/scripting.ts 13:46-88
[tsl] ERROR in /app/assets/src/adaptivity/scripting.ts(13,47)
      TS2569: Type 'IterableIterator<string>' is not an array type or a string type. Use compiler option '--downlevelIteration' to allow iterating of iterators.
ts-loader-default_8e11959e0762e3a1
 @ ./src/adaptivity/rules-engine.ts 72:18-40
 @ ./src/adaptivity/rules.ts 3:21-46

webpack 5.76.0 compiled with 1 error in 10896 ms

This issue was outlined in microsoft/TypeScript#8856. There are a few solutions proposed. One is compiling with the --downlevelIteration flag as the error message indicates, but this can cause adverse performance effects. I ultimately decided to just wrap the Set being being spread in Array.from().

@eliknebel eliknebel changed the title [CHORE] Fixes the package build step [CHORE] Fixes the CI package build step Nov 7, 2023
@eliknebel eliknebel merged commit f2e7f1a into master Nov 7, 2023
10 checks passed
@eliknebel eliknebel deleted the fix-package-CI-workflow branch November 7, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant