Only dispose of instance if all playerKeys are removed #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -279,7 +279,7 @@ class PlayerController extends ChangeNotifier { | |||
| if (playerState != PlayerState.stopped) await stopPlayer(); | |||
| await release(); | |||
| PlatformStreams.instance.playerControllerFactory.remove(playerKey); | |||
| if (PlatformStreams.instance.playerControllerFactory.length == 1) { | |||
| if (PlatformStreams.instance.playerControllerFactory.isEmpty) { | |||
There was a problem hiding this comment.
Oh! Quite an oversight.
ujas-m-simformsolutions
approved these changes
Jul 30, 2024
hemantbeast
pushed a commit
to hemantbeast/audio_waveforms
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently the dispose method will remove the platform instance if there is still one player currently activate.
Fix
Wait until all players are being disposed to remove the platform instance.