Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - 230/Stop player should not be freed the resources #268

Merged

Conversation

himanshuGandhiSimform
Copy link
Collaborator

Enhancement - implement audio player freed resource functionality.

Copy link
Collaborator

@ujas-m-simformsolutions ujas-m-simformsolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do remove unnecessary file changes.

ios/Classes/Utils.swift Outdated Show resolved Hide resolved
lib/src/base/audio_waveforms_interface.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@ujas-m-simformsolutions ujas-m-simformsolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove necessary IOS file changes and we can merge this

@himanshuGandhiSimform himanshuGandhiSimform merged commit 538b3d4 into main Mar 1, 2024
@himanshuGandhiSimform himanshuGandhiSimform deleted the fix/230/stop_player_should_not_freed_the_resournce branch March 1, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop player should not be freed the resources
2 participants