Skip to content

Commit

Permalink
update flutter and dart version
Browse files Browse the repository at this point in the history
  • Loading branch information
himanshuGandhiSimform committed Oct 7, 2024
1 parent baee36b commit 4aeaa87
Show file tree
Hide file tree
Showing 13 changed files with 55 additions and 31 deletions.
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
## 2.0.0 (Unreleased)
## 1.1.0

- **Breaking** Dropped support for Flutter < 3.0.0
- Update flutter and dart version
- Fixed [#256](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/256) - Default audio session config causing expected behavior for IOS.
- Fixed [#303](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/303) - All player has same instances - thanks [@AlexV525](https://github.com/AlexV525)
- Fixed incorrect import for shortHash - thanks [@mattbajorek](https://github.com/mattbajorek)
- Fixed Auto start permission on iOS by waiting for response after user confirms or denies - thanks [@mattbajorek](https://github.com/mattbajorek)
- Fixed Dispose of instance if all playerKeys are removed - thanks [@mattbajorek](https://github.com/mattbajorek)

## 1.0.5

Expand Down
26 changes: 23 additions & 3 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,24 @@
include: package:lints/core.yaml
include: package:flutter_lints/flutter.yaml

# Additional information about this file can be found at
# https://dart.dev/guides/language/analysis-options
analyzer:
strong-mode:
implicit-casts: false
implicit-dynamic: false
errors:
argument_type_not_assignable: error
invalid_assignment: error
dead_code: warning
overridden_fields: ignore
use_key_in_widget_constructors: ignore

linter:
rules:
public_member_api_docs: false
avoid_print: true
avoid_empty_else: true
annotate_overrides: true
cancel_subscriptions: true
close_sinks: true
avoid_positional_boolean_parameters: false
use_super_parameters: true
prefer_relative_imports: true
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ android {
namespace "com.simform.audio_waveforms"
}

compileSdk 33
compileSdk 34

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import io.flutter.plugin.common.MethodCall
import io.flutter.plugin.common.MethodChannel
import io.flutter.plugin.common.MethodChannel.MethodCallHandler
import io.flutter.plugin.common.MethodChannel.Result
import io.flutter.plugin.common.PluginRegistry.Registrar
import java.io.File
import java.io.IOException
import java.text.SimpleDateFormat
Expand Down
4 changes: 2 additions & 2 deletions example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ android {
if (project.android.hasProperty("namespace")) {
namespace "com.simform.audio_waveforms_example"
}
compileSdk 33
compileSdk 34

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
Expand All @@ -48,7 +48,7 @@ android {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "com.simform.audio_waveforms_example"
minSdkVersion 21
targetSdkVersion 33
targetSdkVersion 34
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
}
Expand Down
2 changes: 1 addition & 1 deletion example/ios/Runner/AppDelegate.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import UIKit
import Flutter

@UIApplicationMain
@main
@objc class AppDelegate: FlutterAppDelegate {
override func application(
_ application: UIApplication,
Expand Down
10 changes: 5 additions & 5 deletions lib/audio_waveforms.dart
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
library audio_waveforms;
library;

export 'src/audio_file_waveforms.dart';
export 'src/audio_waveforms.dart';
export 'src/base/wave_style.dart';
export 'src/controllers/recorder_controller.dart';
export 'src/base/player_wave_style.dart';
export 'src/base/utils.dart';
export 'src/audio_file_waveforms.dart';
export 'src/base/wave_style.dart';
export 'src/controllers/player_controller.dart';
export 'src/base/player_wave_style.dart';
export 'src/controllers/recorder_controller.dart';
8 changes: 4 additions & 4 deletions lib/src/audio_file_waveforms.dart
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import 'dart:async';

import 'package:audio_waveforms/src/base/wave_clipper.dart';
import 'package:audio_waveforms/src/painters/player_wave_painter.dart';
import 'package:flutter/material.dart';

import '../audio_waveforms.dart';
import 'base/wave_clipper.dart';
import 'painters/player_wave_painter.dart';

class AudioFileWaveforms extends StatefulWidget {
/// A size to define height and width of waveform.
Expand Down Expand Up @@ -71,7 +71,7 @@ class AudioFileWaveforms extends StatefulWidget {
/// With seeking gesture enabled, playing audio can be seeked to
/// any position using gestures.
const AudioFileWaveforms({
Key? key,
super.key,
required this.size,
required this.playerController,
this.waveformData = const [],
Expand All @@ -86,7 +86,7 @@ class AudioFileWaveforms extends StatefulWidget {
this.clipBehavior = Clip.none,
this.waveformType = WaveformType.long,
this.enableSeekGesture = true,
}) : super(key: key);
});

@override
State<AudioFileWaveforms> createState() => _AudioFileWaveformsState();
Expand Down
4 changes: 2 additions & 2 deletions lib/src/audio_waveforms.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class AudioWaveforms extends StatefulWidget {
final bool shouldCalculateScrolledPosition;

const AudioWaveforms({
Key? key,
super.key,
required this.size,
required this.recorderController,
this.waveStyle = const WaveStyle(),
Expand All @@ -28,7 +28,7 @@ class AudioWaveforms extends StatefulWidget {
this.decoration,
this.backgroundColor,
this.shouldCalculateScrolledPosition = false,
}) : super(key: key);
});

@override
State<AudioWaveforms> createState() => _AudioWaveformsState();
Expand Down
3 changes: 1 addition & 2 deletions lib/src/base/platform_streams.dart
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import 'dart:async';

import 'package:audio_waveforms/src/base/player_identifier.dart';

import '../../audio_waveforms.dart';
import 'player_identifier.dart';

///This class should be used for any type of native streams.
class PlatformStreams {
Expand Down
2 changes: 1 addition & 1 deletion lib/src/base/utils.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:audio_waveforms/src/base/player_identifier.dart';
import 'player_identifier.dart';

//ignore_for_file: constant_identifier_names
extension DurationExtension on Duration {
Expand Down
9 changes: 5 additions & 4 deletions lib/src/controllers/player_controller.dart
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import 'dart:async';
import 'dart:io';

import 'package:audio_waveforms/audio_waveforms.dart';
import 'package:audio_waveforms/src/base/constants.dart';
import 'package:audio_waveforms/src/base/platform_streams.dart';
import 'package:audio_waveforms/src/base/player_identifier.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart';

import '../../audio_waveforms.dart';
import '../base/constants.dart';
import '../base/platform_streams.dart';
import '../base/player_identifier.dart';

part '../base/audio_waveforms_interface.dart';

class PlayerController extends ChangeNotifier {
Expand Down
7 changes: 4 additions & 3 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ homepage: https://github.com/SimformSolutionsPvtLtd/audio_waveforms
issue_tracker: https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues

environment:
sdk: ">=2.12.0 <4.0.0"
flutter: ">=1.20.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

dependencies:
flutter:
Expand All @@ -15,7 +15,8 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
lints: ^3.0.0
flutter_lints: ^5.0.0


flutter:
plugin:
Expand Down

0 comments on commit 4aeaa87

Please sign in to comment.