Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add print targets #2065

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add print targets #2065

merged 1 commit into from
Jun 12, 2024

Conversation

elanalynn
Copy link
Contributor

@elanalynn elanalynn commented Jun 11, 2024 •
edited
Loading

Background

Closes https://github.com/Shopify/app-ui/issues/1249
Related to https://github.com/Shopify/shopify-dev/pull/45395

Solution

  • Add targets in type definition file
  • Add targets to overview page
  • Changeset
  • Images (Will add in follow up)

🎩

See docs PR.

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@MitchLillie MitchLillie merged commit cf1084b into unstable Jun 12, 2024
5 checks passed
@MitchLillie MitchLillie deleted the 1179/print-extension-types branch June 12, 2024 14:53
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchLillie MitchLillie MitchLillie approved these changes

@belalsj belalsj belalsj approved these changes

@tracytees tracytees Awaiting requested review from tracytees

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elanalynn @MitchLillie @belalsj