-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AdminPrintAction component #2040
Conversation
This comment has been minimized.
This comment has been minimized.
9713a50
to
92c50ff
Compare
eefcd07
to
052d61d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩, added a few comments
...t/src/surfaces/admin/components/AdminPrintAction/examples/basic-adminprintaction.example.tsx
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/admin/components/AdminPrintAction/AdminPrintAction.doc.ts
Outdated
Show resolved
Hide resolved
Also one other note: We should probably wait to ship this PR. As soon as it is merged, the component will be available on |
052d61d
to
7a938af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...ns/src/surfaces/admin/components/AdminPrintAction/examples/basic-adminprintaction.example.ts
Outdated
Show resolved
Hide resolved
...t/src/surfaces/admin/components/AdminPrintAction/examples/basic-adminprintaction.example.tsx
Show resolved
Hide resolved
Add changeset
7a938af
to
c8d876e
Compare
Background
Closes https://github.com/Shopify/app-ui/issues/1178
Adds new admin component for the admin print action extension:
AdminPrintAction
Solution
Add component type, docs, and examples for vanilla and react components.
🎩
ui-extensions
runyarn build-consumer print-demo-app
AdminPrintAction
component and run your extensionSample extension code
Checklist