Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add authenticationState api to customer account ui extension #2037

Merged
merged 1 commit into from
May 31, 2024
Merged

add authenticationState api to customer account ui extension #2037

merged 1 commit into from
May 31, 2024

Conversation

brianshen1990
Copy link
Contributor

@brianshen1990 brianshen1990 commented May 29, 2024 •
edited
Loading

Background

Part of https://github.com/Shopify/core-issues/issues/71278
Add a new API to order status api to indicate which authentication state it is.

Please also review the customer account web side PR https://github.com/Shopify/customer-account-web/pull/4626 , same tophat .

🎩

  • go visit https://shopify.renaming.brian-shen.us.spin.dev/3/account/orders/6 => unauthenticated, no extension
  • open dev console, execute document.cookie = "order=eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaEpJaVZrTkRneU5XSXdNVFV3WXpKbFpXUXdPVGszTXprellqazJNbVF4TXpNME1BWTZCa1ZVIiwiZXhwIjoiMjAyNC0wNi0xOVQyMDo1Mzo1Ny44NzdaIiwicHVyIjoiY29va2llLm9yZGVyIn19--7b65fadc7e53ff713ac912d8056ae30018000ce6; Path=/3/account/orders/6" , refresh => extension show, as pre-authenticated
  • login with dev@shopify.com and this identity mailer , extension loads, and show as fully_authenticated

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@brianshen1990 brianshen1990 self-assigned this May 29, 2024
@brianshen1990 brianshen1990 marked this pull request as ready for review May 29, 2024 21:18
deannatron
deannatron approved these changes May 29, 2024
View reviewed changes
Copy link

@deannatron deannatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, content-wise!

PSalmers
PSalmers approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@PSalmers PSalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 LGTM

oluwatimio
oluwatimio approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@oluwatimio oluwatimio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 and code LGTM! Are we going to update the api docs with this change as well?

@brianshen1990
Copy link
Contributor Author

brianshen1990 commented May 31, 2024 •
edited
Loading

🎩 and code LGTM! Are we going to update the api docs with this change as well?

yep, the first sentence of the description of customer account web side https://github.com/Shopify/customer-account-web/pull/4626 ~~ docs on the way~~

@brianshen1990 brianshen1990 merged commit 67d479c into unstable May 31, 2024
6 checks passed
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oluwatimio oluwatimio oluwatimio approved these changes

@PSalmers PSalmers PSalmers approved these changes

@deannatron deannatron deannatron approved these changes

@lihaokx lihaokx Awaiting requested review from lihaokx

@anahita-m anahita-m Awaiting requested review from anahita-m

@jrrafols jrrafols Awaiting requested review from jrrafols

Assignees

@brianshen1990 brianshen1990

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianshen1990 @oluwatimio @PSalmers @deannatron