-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unstable Release (checkout) for address-autocomplete.suggest #1916
Conversation
This comment has been minimized.
This comment has been minimized.
/snapit |
🫰✨ Thanks @mleandres! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20240429192347",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20240429192347" |
packages/ui-extensions/src/surfaces/checkout/components/shared.ts
Outdated
Show resolved
Hide resolved
40c0445
to
b054d71
Compare
/snapit |
🫰✨ Thanks @mleandres! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20240429194829",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20240429194829" |
@@ -4,4 +4,6 @@ import type {ReactPropsFromRemoteComponentType} from '@remote-ui/react'; | |||
|
|||
export type SheetProps = ReactPropsFromRemoteComponentType<typeof BaseSheet>; | |||
|
|||
export const Sheet = createRemoteReactComponent(BaseSheet); | |||
export const Sheet = createRemoteReactComponent(BaseSheet, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine by me, I'll be adding more changes in the docs and the API together with @rcaplanshopify but this can go to unstable today
* This signal is sent when the buyer has stopped interacting with the address field. | ||
*/ | ||
signal: AbortSignal; | ||
field: Extract<keyof MailingAddress, 'address1' | 'zip'>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type is changing in Haylee's doc PR. So you'll need to do another unstable release to bring that change in. No problem with that approach though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, not pushing this until we have the docs PR shipped.
.changeset/yellow-lions-behave.md
Outdated
--- | ||
|
||
- Adds `purchase.address-autocomplete.suggest` extension target | ||
- Adds `Sheet` component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Sheet component already existed, it is just adding some props.
- Adds `Sheet` component | |
- Adds the `primaryAction` and `secondaryAction` to the `Sheet` component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah okay thanks
export interface AllowedProcessing { | ||
/** | ||
* Can collect customer analytics about how the shop was used and interactions made on the shop. | ||
*/ | ||
analytics: boolean; | ||
/** | ||
* Can collect customer preference for marketing, attribution and targeted advertising from the merchant. | ||
*/ | ||
marketing: boolean; | ||
/** | ||
* Can collect customer preferences such as language, currency, size, and more. | ||
*/ | ||
preferences: boolean; | ||
/** | ||
* Can collect customer preference for sharing data with third parties, usually for behavioral advertising. | ||
*/ | ||
saleOfData: boolean; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rcaplanshopify can this change be released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we were going to release it with the custom metadata update for efficiency, but there's no reason to delay the release of the allowed processing flags
c3b766e
to
da449d3
Compare
3a43333
to
f9a593e
Compare
Background
This PR will update
unstable
packages with the latest changesSolution
generated by running
pnpm prepare-package-release
🎩
tophatted on my prod store with the snapshot and an address-autocomplete extension.
Checklist