Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable Release (checkout) for address-autocomplete.suggest #1916

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

mleandres
Copy link
Contributor

@mleandres mleandres commented Apr 29, 2024

Background

This PR will update unstable packages with the latest changes

Solution

generated by running pnpm prepare-package-release

🎩

tophatted on my prod store with the snapshot and an address-autocomplete extension.

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

This comment has been minimized.

@mleandres
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @mleandres! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/ui-extensions": "0.0.0-snapshot-20240429192347",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20240429192347"

@mleandres
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @mleandres! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/ui-extensions": "0.0.0-snapshot-20240429194829",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20240429194829"

@@ -4,4 +4,6 @@ import type {ReactPropsFromRemoteComponentType} from '@remote-ui/react';

export type SheetProps = ReactPropsFromRemoteComponentType<typeof BaseSheet>;

export const Sheet = createRemoteReactComponent(BaseSheet);
export const Sheet = createRemoteReactComponent(BaseSheet, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine by me, I'll be adding more changes in the docs and the API together with @rcaplanshopify but this can go to unstable today

* This signal is sent when the buyer has stopped interacting with the address field.
*/
signal: AbortSignal;
field: Extract<keyof MailingAddress, 'address1' | 'zip'>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type is changing in Haylee's doc PR. So you'll need to do another unstable release to bring that change in. No problem with that approach though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, not pushing this until we have the docs PR shipped.

---

- Adds `purchase.address-autocomplete.suggest` extension target
- Adds `Sheet` component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sheet component already existed, it is just adding some props.

Suggested change
- Adds `Sheet` component
- Adds the `primaryAction` and `secondaryAction` to the `Sheet` component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay thanks

Comment on lines +1721 to +1739
export interface AllowedProcessing {
/**
* Can collect customer analytics about how the shop was used and interactions made on the shop.
*/
analytics: boolean;
/**
* Can collect customer preference for marketing, attribution and targeted advertising from the merchant.
*/
marketing: boolean;
/**
* Can collect customer preferences such as language, currency, size, and more.
*/
preferences: boolean;
/**
* Can collect customer preference for sharing data with third parties, usually for behavioral advertising.
*/
saleOfData: boolean;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcaplanshopify can this change be released?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we were going to release it with the custom metadata update for efficiency, but there's no reason to delay the release of the allowed processing flags

@mleandres mleandres merged commit a7a39ba into unstable Apr 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants