Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Extension Target for Reorder Flow #1807

Merged
merged 1 commit into from
May 7, 2024
Merged

Add Extension Target for Reorder Flow #1807

merged 1 commit into from
May 7, 2024

Conversation

nataliejeong
Copy link
Contributor

@nataliejeong nataliejeong commented Mar 5, 2024 •
edited
Loading

Background

Fix #122087

This PR adds the reorder target in the ui-extensions directory.

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@nataliejeong nataliejeong changed the title Add Extension Target for Reorder Render Add New Extension Point for Reorder Flow Mar 6, 2024
@nataliejeong nataliejeong changed the title Add New Extension Point for Reorder Flow Add New Extension Target for Reorder Flow Mar 6, 2024
@nataliejeong nataliejeong changed the title Add New Extension Target for Reorder Flow [Prototype] Add New Extension Target for Reorder Flow Mar 6, 2024
@nataliejeong nataliejeong reopened this Apr 9, 2024
@nataliejeong nataliejeong changed the title [Prototype] Add New Extension Target for Reorder Flow Add New Extension Target for Reorder Flow Apr 9, 2024
@nataliejeong nataliejeong changed the title Add New Extension Target for Reorder Flow Add Extension Target for Reorder Flow Apr 9, 2024
@nataliejeong nataliejeong force-pushed the nj-reorder-render branch 2 times, most recently from 1d02674 to b035e5d Compare April 9, 2024 20:51
@nataliejeong nataliejeong marked this pull request as ready for review April 9, 2024 20:52
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@nataliejeong nataliejeong marked this pull request as draft April 10, 2024 15:38
elanalynn
elanalynn approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@elanalynn elanalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/ui-extensions/src/surfaces/admin/extension-targets.ts Outdated Show resolved Hide resolved
@nataliejeong nataliejeong marked this pull request as ready for review May 7, 2024 13:12
@nataliejeong
Copy link
Contributor Author

nataliejeong commented May 7, 2024 •
edited
Loading

Requesting another set of reviews as I noticed the extension-targets file has moved since I last put up this PR, so just want to make sure changes are still valid (including .changeset) before merging. Thanks!

@nataliejeong nataliejeong merged commit a4eea7d into unstable May 7, 2024
5 checks passed
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elanalynn elanalynn elanalynn approved these changes

@gdube gdube gdube approved these changes

@MitchLillie MitchLillie Awaiting requested review from MitchLillie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nataliejeong @elanalynn @gdube